Goal account renewpartkey: cannot construct transaction: txn validity period is greater than protocol max txn lifetime 1000

fabrice · December 7, 2021, 6:37pm

Indeed, this looks like a bug.
I’ve made a report:

`goal account renewpartkey` does not separate transaction validity from partkey validity

opened 06:36PM - 07 Dec 21 UTC

new-bug

### Subject of the issue Reported by mstuder on https://forum.algorand.co/t/…goal-account-renewpartkey-cannot-construct-transaction-txn-validity-period-is-greater-than-protocol-max-txn-lifetime-1000/5333?u=fabrice `goal account renewpartkey` uses `roundLastValid` both for transaction validity and partkey validity. This means that partkeys renewed this way can only last at most 1000 rounds. This can be seen in the arguments of: https://github.com/algorand/go-algorand/blob/387f6a62fb29d1a02968112601f7192710ab713c/cmd/goal/account.go#L959 ### Your environment ``` $ ./sandbox goal version -v Version: [v1 v2] GenesisID: sandnet-v1 Build: 3.1.0.nightly [relbeta3.1.0] (commit #83740b45+) $ ./sandbox goal node status Last committed block: 135 Time since last block: 3.5s Sync Time: 0.0s Last consensus protocol: future Next consensus protocol: future Round for next consensus protocol: 136 Next consensus protocol supported: true Last Catchpoint: Genesis ID: sandnet-v1 Genesis hash: SICdQ+nhcQiu13tqol+neGty9wdlrc0OA6Dlepn1ylE= ``` ### Steps to reproduce 1. Start sandbox `./sandbox up` 2. List the accounts `./sandbox account list`. Assume that account list contains `VF5SXUXEST4NUMQYDV5KSNOWEESQEYIWY4PAVL4K6QAFD5EBT3LIK6RDJE` 3. Renew the above key: ``` ./sandbox goal account renewpartkey --address VF5SXUXEST4NUMQYDV5KSNOWEESQEYIWY4PAVL4K6QAFD5EBT3LIK6RDJE --roundLastValid 10000000 ``` ### Expected behaviour It should work. ### Actual behaviour It fails: ``` $ ./sandbox goal account renewpartkey --address VF5SXUXEST4NUMQYDV5KSNOWEESQEYIWY4PAVL4K6QAFD5EBT3LIK6RDJE --roundLastValid 10000000 Generated participation key for VF5SXUXEST4NUMQYDV5KSNOWEESQEYIWY4PAVL4K6QAFD5EBT3LIK6RDJE (Valid 80 - 10000000) Error registering keys - deleting newly-generated key file: /opt/data/sandnet-v1/VF5SXUXEST4NUMQYDV5KSNOWEESQEYIWY4PAVL4K6QAFD5EBT3LIK6RDJE.80.10000000.partkey cannot construct transaction: txn validity period ( 80 to 10000000 ) is greater than protocol max txn lifetime 1000 ```

Thanks for the feedback!

Topic		Replies	Views
Generate Participation Key getting error txn validity period is greater than protocol max txn lifetime 1000 General mainnet	3	608	January 19, 2021
Consensus Participation	2	538	July 4, 2021
Participation key docs need updated General	5	602	April 27, 2020
1000 Rounds of Consensus General	1	391	July 31, 2020
Goal clerk password	8	711	January 6, 2021

Goal account renewpartkey: cannot construct transaction: txn validity period is greater than protocol max txn lifetime 1000

Related topics